Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix report mentions characters limit #796

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix report mentions characters limit #796

merged 1 commit into from
Sep 9, 2024

Conversation

NJ-2020
Copy link
Contributor

@NJ-2020 NJ-2020 commented Sep 5, 2024

Fixed Issues

$ Expensify/App#48168

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?
  3. Open Expensify App
  4. Tap fab - start chat -- room
  5. Create 2 room with name more than 80 characters long (max 99)
  6. Mention any room with name more than 80 characters
  7. Verify that the room mention is shown in whisper

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?
  3. Same as above

@NJ-2020 NJ-2020 requested a review from a team as a code owner September 5, 2024 12:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NJ-2020
Copy link
Contributor Author

NJ-2020 commented Sep 5, 2024

I have read the CLA Document and I hereby sign the CLA

@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team September 5, 2024 12:54
@NJ-2020
Copy link
Contributor Author

NJ-2020 commented Sep 5, 2024

recheck

@NJ-2020 NJ-2020 changed the title fix characters limit fix report mentions characters limit Sep 5, 2024
techievivek
techievivek approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, cc @alitoshmatov @BStitesExpensify since you are managing the linked GH Expensify/App#48168

@techievivek techievivek merged commit 98c6259 into Expensify:main Sep 9, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

🚀Published to npm in v2.0.85

@trjExpensify trjExpensify mentioned this pull request Sep 9, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techievivek techievivek techievivek approved these changes

Assignees

@NJ-2020 NJ-2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NJ-2020 @techievivek